[MAINT] update tests to check content of EMG, eyetracking and atlas datasets#1221
[MAINT] update tests to check content of EMG, eyetracking and atlas datasets#1221Remi-Gau wants to merge 4 commits intobids-standard:mainfrom
Conversation
| assert len(files) == nb_files No newline at end of file | ||
| assert len(files) == nb_files | ||
|
|
||
| @pytest.mark.xfail(reason="atlas datasets are not fully supported in pybids") |
There was a problem hiding this comment.
those currently fail: I would expect that given the current configs we have
| ("emg_ConcurrentIndependentUnits", 18), | ||
| ("emg_CustomBipolar", 7), | ||
| ("emg_CustomBipolarFace", 11), | ||
| ("emg_IndependentMod", 7), | ||
| ("emg_MultiBodyParts", 10), | ||
| ("emg_Multimodal", 21), | ||
| ("emg_TwoHDsEMG", 12), | ||
| ("emg_TwoWristbands", 10), | ||
| ("eyetracking_binocular", 21), | ||
| ("eyetracking_fmri", 30), |
There was a problem hiding this comment.
I am a bit more confused as to why those pass given that some files from those datasets have entities, suffixes that do not appear in the config
I must be missing something obvious
I am tired
There was a problem hiding this comment.
They should pass because the validator is now schema based.
There was a problem hiding this comment.
ha yes you mentioned
but what becomes of the config file then?
There was a problem hiding this comment.
also those are failing with the min dependencies: https://github.com/bids-standard/pybids/actions/runs/22472040716/job/65090910932?pr=1221#step:10:1647
There was a problem hiding this comment.
I suppose we could make those tests contingent on the bidsschematools version?
The config file needs updating to give you access to new entities (or you can use @astewartau's recent contribution in #1215),
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1221 +/- ##
==========================================
- Coverage 89.53% 89.50% -0.04%
==========================================
Files 70 70
Lines 7828 7834 +6
Branches 951 951
==========================================
+ Hits 7009 7012 +3
- Misses 580 583 +3
Partials 239 239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
closes none
mostly to keep track of the last release